ci: add macos and windows and more robust scandir tests #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
force-pushed
the
macos_scandir
branch
12 times, most recently
from
bf97a40
to
c6ed710
Compare
Conni2461
force-pushed
the
macos_scandir
branch
17 times, most recently
from
eec1461
to
8b83bda
Compare
Conni2461
force-pushed
the
macos_scandir
branch
8 times, most recently
from
04387f8
to
c1997cd
Compare
Conni2461
commented
Feb 22, 2021
| @@ -106,7 +116,7 @@ describe('Job', function() | |||
|
|
|||
| job:sync() | |||
|
|
|||
| assert.are.same(job:result(), { 'A=100' }) | |||
| assert.are.same(true, contains(job:result(), { 'A=100' })) | |||
There was a problem hiding this comment.
Windows doesn't get a clean env. Or maybe it is a clean env but windows needs like 100 env vars to even function 🤣 Idk we just check that it contains now. Doesn't matter
Conni2461
force-pushed
the
macos_scandir
branch
from
c1997cd
to
f6aa1c6
Compare
Conni2461
changed the title
Conni2461
changed the title
Conni2461
commented
Feb 22, 2021
| @@ -31,6 +34,11 @@ end) | |||
| function harness.test_directory_command(command) | |||
| local split_string = vim.split(command, " ") | |||
| local directory = table.remove(split_string, 1) | |||
| if is_windows then | |||
| for k, v in ipairs(split_string) do | |||
| split_string[k] = v:gsub('\\', '\\\\') | |||
There was a problem hiding this comment.
First we need to do that because we fail because of some escape char. So we do that and afterwards we move back to /
|
Closing. I don't wanna implement windows support. I might port the more robust scandir tests and the mac ci. Some other time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI doesn't show me any issues for scandir when using macos.
I probably should also add windows ci and port that to telescope at some point :)
CC @clason